Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement create tenant & project detail logic #181

Merged
merged 9 commits into from Feb 8, 2023
Merged

implement create tenant & project detail logic #181

merged 9 commits into from Feb 8, 2023

Conversation

masskoder
Copy link
Contributor

@masskoder masskoder commented Feb 7, 2023

Scope of changes

This adds :

  • Create tenant logic which includes

    • tenant API adapter
    • create a tenant service type
    • create tenant API service
    • unit test
  • Also added Project detail logic :

    • project API adapter
    • project service type
    • get project detail by id API service
  • Registration Form issue fixes

  • Separate auth logic

  • fix copy typo in login page and registration view

Fixes SC-XXXX

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@shortcut-integration
Copy link

@masskoder masskoder changed the title feat: add create tenant logic implement create tenant & project detail logic Feb 8, 2023
@@ -6,7 +6,7 @@ function Logo() {
return (
<Link to="/" data-testid="logo">
<div className="flex items-center space-x-2">
<img src={RotationalLogo} alt="Rotational Labs" className="h-12 w-12" />
<img src={RotationalLogo} alt="Rotational Lab" className="h-12 w-12" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it Rotational Lab or Rotational Labs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Labs, Edwin added this comment here SC-13574

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess it's the conflict resolution that changes it. thanks for catching that.

@elysee15 elysee15 self-requested a review February 8, 2023 15:55
@masskoder masskoder merged commit 4ceb071 into main Feb 8, 2023
@masskoder masskoder deleted the sc-12462 branch February 8, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants