Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email builders #183

Merged
merged 1 commit into from Feb 7, 2023
Merged

Email builders #183

merged 1 commit into from Feb 7, 2023

Conversation

pdeziel
Copy link
Contributor

@pdeziel pdeziel commented Feb 7, 2023

Scope of changes

This adds some builder utilities which create sendgrid emails from templates. The templates are loaded from a directory using go:embed to ensure that they exist at compile time.

The welcome email template is stub for right now to make sure the process is working.

Fixes SC-13278

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

This story is mostly about making sure that the template strategy works and it unblocks the template creation stories.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #13278: Create Email Templates using Go Embed.

Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! go:embed is so much easier than go-bindata!

@bbengfort bbengfort merged commit b74550d into main Feb 7, 2023
@bbengfort bbengfort deleted the sc-13278 branch February 7, 2023 22:44
@pdeziel pdeziel restored the sc-13278 branch February 9, 2023 21:42
@bbengfort bbengfort deleted the sc-13278 branch May 12, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants