Adds ensign mock to tenant test #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #13767: Add Ensign Mock to Tenant Tests. |
daniellemaxwell
commented
Feb 15, 2023
| @@ -53,6 +55,9 @@ func (suite *tenantTestSuite) SetupSuite() { | |||
| // Ensure Quarterdeck returns a 200 on status so Tenant knows it's ready | |||
| suite.quarterdeck.OnStatus(mock.UseStatus(http.StatusOK)) | |||
|
|
|||
| // Start a server to handle mock requests to Ensign | |||
| suite.ensign = emock.New(nil) | |||
There was a problem hiding this comment.
The New method doesn't return an error. Benjamin confirmed that it doesn't need to since there aren't any side effects and an interface isn't required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Adds Ensign mock to the tenant test.
Fixes SC-13767
Type of change
Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.
Author checklist
Reviewer(s) checklist