Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications Signup Endpoint #22

Merged
merged 4 commits into from Sep 29, 2022
Merged

Notifications Signup Endpoint #22

merged 4 commits into from Sep 29, 2022

Conversation

bbengfort
Copy link
Contributor

Scope of changes

This is a very hacked together implementation of the Notifications Signup endpoint -- I tested it manually and was able to register a contact in SendGrid. There are a lot of TODOs though in the code; a lot of things are hard coded that probably shouldn't be. However, as long as we don't mess with SendGrid too much, this should get us through the next couple of weeks.

Fixes SC-9682

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

I think the best way to validate this is if I do a local demo to show it working. Let me know if you want to hop on a quick call to do that.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • I've verified that it works with sendgrid

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #9682: Tenant API /v1/notifications/signup.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #22 (9bd4c1d) into main (2a7e818) will decrease coverage by 1.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   59.11%   57.59%   -1.52%     
==========================================
  Files          34       35       +1     
  Lines        2047     2132      +85     
==========================================
+ Hits         1210     1228      +18     
- Misses        747      811      +64     
- Partials       90       93       +3     
Flag Coverage Δ
unittests 57.59% <ø> (-1.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/rotationalio/ensign/pkg/tenant/api/v1/client.go 56.36% <0.00%> (-2.06%) ⬇️
...om/rotationalio/ensign/pkg/tenant/config/config.go 73.91% <0.00%> (-0.38%) ⬇️
...om/rotationalio/ensign/pkg/tenant/notifications.go 0.00% <0.00%> (ø)
...ithub.com/rotationalio/ensign/pkg/tenant/tenant.go 80.45% <0.00%> (+0.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

docs/content/system/configuration.md Outdated Show resolved Hide resolved
bbengfort and others added 2 commits September 29, 2022 14:24
Co-authored-by: Danielle <danielle@rotational.io>
@bbengfort bbengfort merged commit 0509ce2 into main Sep 29, 2022
@bbengfort bbengfort deleted the sc-9682/sg-contacts branch September 29, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants