Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lingui trans error #252

Merged
merged 2 commits into from Feb 25, 2023
Merged

fix: lingui trans error #252

merged 2 commits into from Feb 25, 2023

Conversation

elysee15
Copy link
Contributor

Scope of changes

Fixes SC-14310

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/14310/fix-lingui-trans-error

We have a ReferenceError: Trans is not defined is prod so I removed the Trans tag until I solve the issue

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@masskoder masskoder merged commit bb093dc into main Feb 25, 2023
@masskoder masskoder deleted the fix/lingui-trans-error branch February 25, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants