Adds login button to verify account page #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #14239: Add Login Button to Confirmation Page. |
masskoder
suggested changes
Feb 27, 2023
|
|
||
| import Logo from '@/components/common/Logo'; | ||
|
|
||
| function LandingHeader() { | ||
| const location = useLocation(); |
There was a problem hiding this comment.
Suggested change
| const location = useLocation(); | |
| const location = useLocation(); | |
| const isConfirmationPage = location.pathname === APP_PATH.VERIFY_PAGE |
There was a problem hiding this comment.
APP_PATH isn't listed in the paths file, so I added /verify-account to ROUTES.
| return ( | ||
| <nav className="border-b border-primary-800 py-8"> | ||
| <div className="container mx-auto flex flex-wrap items-center justify-between"> | ||
| <Logo /> | ||
| <div className="space-x-8"> | ||
| {login && ( |
There was a problem hiding this comment.
Suggested change
| {login && ( | |
| {isConfirmationPage && ( |
masskoder
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Adds a log in button to the header that should only appear on the verify-account page, after a user has completed the registration process.
Fixes SC-14239
Type of change
Acceptance criteria
https://www.awesomescreenshot.com/video/15164591?key=b5ddc0cc7cfd878515285309d786fecc
Author checklist
Reviewer(s) checklist