Send verification email in async task #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #14589: Create task to resend email on failure. |
pdeziel
commented
Mar 2, 2023
| @@ -347,7 +347,7 @@ func (s *Server) TenantStats(c *gin.Context) { | |||
| Count: int64(totalKeys), | |||
| }, | |||
| { | |||
| Name: "usage_kbytes", | |||
| Name: "storage", | |||
There was a problem hiding this comment.
Request from @masskoder
There was a problem hiding this comment.
Probably if we're going to change this we should make the usage a string with the units in the string rather than a number. We can follow up on that later though.
pdeziel
commented
Mar 2, 2023
| @@ -116,6 +117,7 @@ func (s *quarterdeckTestSuite) TestRegister() { | |||
| s.CheckError(err, http.StatusConflict, "user or organization already exists") | |||
|
|
|||
| // Test that one verify email was sent to each user | |||
| s.StopTasks() | |||
There was a problem hiding this comment.
I think this should avoid the race condition for now, let me know if there's a more delicate way to wait for the current tasks to stop without having to reset the entire task manager.
There was a problem hiding this comment.
Ah, I didn't think about race conditions with respect to the tests. You're right that this is a pretty tricky situation.
bbengfort
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
This updates the Quarterdeck register endpoint so that we're not blocked waiting for emails to send after the user has been created in the database.
Fixes SC-14589
Type of change
Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.
Author checklist
Reviewer(s) checklist