Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sc-13560 Floating passwords check #286

Merged
merged 2 commits into from Mar 10, 2023
Merged

sc-13560 Floating passwords check #286

merged 2 commits into from Mar 10, 2023

Conversation

elysee15
Copy link
Contributor

@elysee15 elysee15 commented Mar 9, 2023

Scope of changes

Fixes SC-13560

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

https://app.shortcut.com/rotational/story/13560/floating-passwords-check

Enregistrement.de.l.ecran.2023-03-09.a.11.39.03.mov

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #13560: Floating passwords check.

@elysee15 elysee15 requested a review from masskoder March 9, 2023 11:39
@elysee15 elysee15 force-pushed the sc-13560 branch 2 times, most recently from 83ad163 to 12fa0e0 Compare March 9, 2023 12:13
@masskoder masskoder merged commit 9cb869b into main Mar 10, 2023
@masskoder masskoder deleted the sc-13560 branch March 10, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masskoder masskoder masskoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elysee15 @masskoder