Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sc-14673: implement email verification feature #287

Merged
merged 16 commits into from Mar 9, 2023
Merged

Sc-14673: implement email verification feature #287

merged 16 commits into from Mar 9, 2023

Conversation

masskoder
Copy link
Contributor

@masskoder masskoder commented Mar 9, 2023 •
edited

Scope of changes

This adds :

  • email verification logic
  • add verify page component
  • refact landing header
  • remove domain url

Fixes SC-XXXX

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

image

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #14673: Fix Beacon UI Issues (Round 3).

@masskoder masskoder requested a review from elysee15 March 9, 2023 12:31
@masskoder masskoder merged commit f1e5f74 into main Mar 9, 2023
@masskoder masskoder deleted the sc-14673 branch March 9, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elysee15 elysee15 elysee15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masskoder @elysee15