Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quarterdeck user id as member id #289

Merged
merged 1 commit into from Mar 9, 2023
Merged

Use quarterdeck user id as member id #289

merged 1 commit into from Mar 9, 2023

Conversation

pdeziel
Copy link
Contributor

@pdeziel pdeziel commented Mar 9, 2023

Scope of changes

This updates the Tenant register method so that the Quarterdeck user ID is used as the member ID. This fixes an issue with the Member Detail endpoint that the frontend was experiencing because it was expecting the member ID to be in the user claims.

Fixes SC-14814

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

After registering a new user the member detail endpoint should return data instead of the 404 if the user ID in the claims is used in the request.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #14814: Use QD user ID as member ID.

@@ -98,7 +98,6 @@ services:
- ./quarterdeck/keys:/data/keys
- ./quarterdeck/emails:/data/emails
environment:
- QUARTERDECK_SENDGRID_TESTING=true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing a duplicate variable which was preventing me from building the containers.

Copy link
Contributor

@pdamodaran pdamodaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @pdeziel

@pdeziel pdeziel merged commit 7e6faa1 into main Mar 9, 2023
@pdeziel pdeziel deleted the sc-14814 branch March 9, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants