Add owner to organization detail response #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #14813: Return owner in organization detail. |
pdeziel
commented
Mar 9, 2023
| // Get the organization owner | ||
| if out.Owner, err = getOwner(ctx, org); err != nil { | ||
| log.Error().Err(err).Str("org", org.ID.String()).Msg("could not retrieve organization owner") | ||
| } |
There was a problem hiding this comment.
An organization not having an owner should probably not happen so we want to know about it. However, I don't think returning an error to the user is necessary (it just blocks the user from being able to view the rest of the organization record). Let me know what you think about that.
pdamodaran
approved these changes
Mar 9, 2023
| // Get the organization owner | ||
| if out.Owner, err = getOwner(ctx, org); err != nil { | ||
| log.Error().Err(err).Str("org", org.ID.String()).Msg("could not retrieve organization owner") | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
This adds the owner name to organization detail response in Tenant so that Beacon can display it along with the other organization data.
Fixes SC-14813
Type of change
Acceptance criteria
Owner name should be added to the org detail response, or an empty string if the owner can't be retrieved.
Author checklist
Reviewer(s) checklist