Sc-13623 : make domain input editable #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #13623: In domain field, use should be able to edit organization slug. |
elysee15
reviewed
Mar 20, 2023
| @@ -75,7 +84,7 @@ function RegistrationForm({ onSubmit }: RegistrationFormProps) { | |||
| data-testid="name" | |||
| fullWidth | |||
| errorMessage={touched.name && errors.name} | |||
| errorMessageClassName="py-1" | |||
| errorMessageClassName="py-2" | |||
There was a problem hiding this comment.
could you add this in the parent component to avoid inconsistency ?
| @@ -84,7 +93,7 @@ function RegistrationForm({ onSubmit }: RegistrationFormProps) { | |||
| fullWidth | |||
| data-testid="email" | |||
| errorMessage={touched.email && errors.email} | |||
| errorMessageClassName="py-1" | |||
| errorMessageClassName="py-2" | |||
There was a problem hiding this comment.
I think this kind of modification should not be specific to a single component
There was a problem hiding this comment.
You are right thanks for catching that. I add this directly to the design system package.
elysee15
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Added a few minor fixes to the registration form and refactored the domain input field so it can be edited
Fixes SC-XXXX
Type of change
Acceptance criteria
https://www.awesomescreenshot.com/video/15772848?key=9fe546b3a916df37272abc3905fa94f9
Author checklist
Reviewer(s) checklist