Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved footer image to background image #37

Merged
merged 8 commits into from Oct 14, 2022
Merged

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Oct 14, 2022

Scope of changes

Adjusted styling to header and footer to correct aspect ratio issues. Updated confirmation page copy.

Fixes SC-9747, SC-10063

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov upload limit reached ⚠️

This org is currently on the free Basic Plan; which includes 250 free private repo uploads each rolling month. This limit has been reached and additional reports cannot be generated. For unlimited uploads, upgrade to our pro plan.

Do you have questions or need help? Connect with our sales team today at sales@codecov.io

@daniellemaxwell daniellemaxwell marked this pull request as ready for review October 14, 2022 18:47
Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thank you for making those changes and updating the configuration docs!

docs/content/system/configuration.md Outdated Show resolved Hide resolved
docs/content/system/configuration.md Outdated Show resolved Hide resolved
daniellemaxwell and others added 2 commits October 14, 2022 16:57
Co-authored-by: Benjamin Bengfort <benjamin@rotational.io>
Co-authored-by: Benjamin Bengfort <benjamin@rotational.io>
@daniellemaxwell daniellemaxwell merged commit 3fab552 into main Oct 14, 2022
@daniellemaxwell daniellemaxwell deleted the background-images branch October 14, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants