Header text corrections #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #10470: The header container should fit the body. |
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 52.32% 52.32%
=======================================
Files 47 47
Lines 3232 3232
=======================================
Hits 1691 1691
Misses 1359 1359
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
daniellemaxwell
requested review from
masskoder
and removed request for
bbengfort
masskoder
approved these changes
Oct 25, 2022
| <h1 className="pb-1 text-xl sm:text-3xl md:text-6xl xl:text-7xl">Ensign</h1> | ||
| <h2 className="font-light text-base sm:text-base md:text-2xl lg:text-4xl">Powering Realtime Experiences</h2> | ||
| <h2 className="font-light text-base sm:text-base md:text-2xl lg:text-4xl">& Data-driven Apps</h2> | ||
| <section className="text-white xl:max-w-7xl mx-auto"> |
There was a problem hiding this comment.
what do you think if you use max-w-7xl on all screens?
There was a problem hiding this comment.
Thanks! I've made the change.
| <Main /> | ||
| <Diagram /> | ||
| <BuildApps /> | ||
| <div className="max-w-xl pl-2 pb-20 mx-auto sm:max-w-2xl lg:max-w-3xl xl:max-w-6xl"> |
There was a problem hiding this comment.
can you try max-w-7xl instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Updated the header so that text remains centered as screen size increased. Adjusted text to be more in line with rotational.io.
Fixes SC-10470 & SC-10475
Type of change
Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.
Author checklist
Reviewer(s) checklist