Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 10279/tenant update #55

Merged
merged 18 commits into from Nov 14, 2022
Merged

Sc 10279/tenant update #55

merged 18 commits into from Nov 14, 2022

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Nov 7, 2022

Scope of changes

Implementation of Tenant Update API definition on the client-side.

Fixes SC-10279

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #10279: Tenant Resource Update API.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #55 (2724413) into main (8c14028) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   47.48%   47.45%   -0.04%     
==========================================
  Files          52       52              
  Lines        3637     3652      +15     
==========================================
+ Hits         1727     1733       +6     
- Misses       1714     1720       +6     
- Partials      196      199       +3     
Flag Coverage Δ
unittests 47.45% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/rotationalio/ensign/pkg/tenant/api/v1/client.go 42.96% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@daniellemaxwell
Copy link
Contributor Author

@bbengfort I resolved merged conflicts for this PR so the changes made in #51 also appear. You can review that one first and then take a look at this one.

@daniellemaxwell daniellemaxwell marked this pull request as ready for review November 10, 2022 16:56
Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small comment and it should be good to go!

pkg/tenant/api/v1/client.go Outdated Show resolved Hide resolved
daniellemaxwell and others added 2 commits November 14, 2022 10:11
Co-authored-by: Benjamin Bengfort <benjamin@rotational.io>
@daniellemaxwell daniellemaxwell merged commit e68d604 into main Nov 14, 2022
@daniellemaxwell daniellemaxwell deleted the sc-10279/tenant-update branch November 14, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants