Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemberDetail and MemberDelete definitions #61

Merged
merged 2 commits into from Nov 18, 2022

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Nov 17, 2022

Scope of changes

Adds MemberDetail and MemberDelete definitions to the Tenant API along with corresponding tests. This is a short PR.

Fixes SC-10364

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #10364: Member Resource Detail/Delete API.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #61 (5a89f4d) into main (424d29d) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   50.47%   50.39%   -0.09%     
==========================================
  Files          52       52              
  Lines        3895     3925      +30     
==========================================
+ Hits         1966     1978      +12     
- Misses       1666     1678      +12     
- Partials      263      269       +6     
Flag Coverage Δ
unittests 50.39% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/rotationalio/ensign/pkg/tenant/api/v1/client.go 41.75% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@daniellemaxwell daniellemaxwell marked this pull request as ready for review November 18, 2022 14:44
Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@daniellemaxwell daniellemaxwell merged commit a6fb921 into main Nov 18, 2022
@daniellemaxwell daniellemaxwell deleted the sc-10364/member-detail-delete branch November 18, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants