Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopicDetail and TopicDelete definitions #63

Merged
merged 3 commits into from Nov 18, 2022

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Nov 17, 2022

Scope of changes

Adds TopicDetail and TopicDelete definitions to the Tenant API along with corresponding tests. This PR should take a few minutes to review.

Fixes SC-10369

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #10369: Topic Resource Detail/Delete API.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #63 (2365e04) into main (a6fb921) will not change coverage.
The diff coverage is n/a.

❗ Current head 2365e04 differs from pull request most recent head 603997b. Consider uploading reports for the commit 603997b to get more accurate results

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   50.39%   50.39%           
=======================================
  Files          52       52           
  Lines        3925     3925           
=======================================
  Hits         1978     1978           
  Misses       1678     1678           
  Partials      269      269           
Flag Coverage Δ
unittests 50.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/rotationalio/ensign/pkg/tenant/api/v1/client.go 41.75% <0.00%> (ø)
...om/rotationalio/ensign/pkg/tenant/api/v1/errors.go 79.16% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@daniellemaxwell daniellemaxwell marked this pull request as ready for review November 18, 2022 15:03
Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're getting close to the end of the first phase API definitions! Looking forward to start working on the server handlers!

@daniellemaxwell daniellemaxwell merged commit 8ed3c5e into main Nov 18, 2022
@daniellemaxwell daniellemaxwell deleted the sc-10369/topic-detail-delete branch November 18, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants