Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 11779/members db #71

Merged
merged 11 commits into from Dec 14, 2022
Merged

Sc 11779/members db #71

merged 11 commits into from Dec 14, 2022

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Dec 6, 2022

Scope of changes

This adds the Members database that the TenantAPI will connect to for server-side requests. It mimics the tenants db. Tenants db tests may be viewed here.

Approval of this PR will allow server-side handler implementation to begin for the members resource.

Fixes SC-11779

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #11779: Create members db and members db test.

@daniellemaxwell daniellemaxwell marked this pull request as ready for review December 9, 2022 17:31
Copy link

@DanielSollis DanielSollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had a quick question and found a few small typos.

pkg/tenant/db/members.go Outdated Show resolved Hide resolved
pkg/tenant/db/members.go Outdated Show resolved Hide resolved
pkg/tenant/db/members.go Show resolved Hide resolved
pkg/tenant/db/members_test.go Show resolved Hide resolved
@daniellemaxwell daniellemaxwell merged commit f5daeb2 into main Dec 14, 2022
@daniellemaxwell daniellemaxwell deleted the sc-11779/members-db branch December 14, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants