Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sc 10412/member update #78

Merged
merged 3 commits into from Dec 20, 2022
Merged

Sc 10412/member update #78

merged 3 commits into from Dec 20, 2022

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Dec 20, 2022 •
edited

Scope of changes

Adds the MemberUpdate server-side handler to the Tenant API that will allow member records to be updated in the database.

Fixes SC-10412

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #10412: Implement Member Resource Update Handlers.

bbengfort
bbengfort approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done - seems like we're getting into the groove with these API methods!

pkg/tenant/members.go Outdated Show resolved Hide resolved
@daniellemaxwell @bbengfort
Update pkg/tenant/members.go
aa2802c 
Co-authored-by: Benjamin Bengfort <benjamin@rotational.io>
@daniellemaxwell daniellemaxwell merged commit 027b8c2 into main Dec 20, 2022
@daniellemaxwell daniellemaxwell deleted the sc-10412/member-update branch December 20, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbengfort bbengfort bbengfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniellemaxwell @bbengfort