Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rotationalio page links to footer #824

Merged
merged 2 commits into from Dec 15, 2023
Merged

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Dec 14, 2023

Scope of changes

Adds links in the footer to the following pages:

  • Ensign Pricing
  • Ensign U
  • Resources

Fixes SC-22997

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

https://www.awesomescreenshot.com/image/44885228?key=d907f61181028bec6cd0361b69574a86

Definition of Done

  • I have manually tested the change running it locally (having rebuilt all containers) or via unit tests
  • I have added unit and/or integration tests that cover my changes
  • I have added new test fixtures as needed to support added tests
  • I have updated the dependencies list if necessary (including updating yarn.lock and/or go.sum)
  • I have recompiled and included new protocol buffers to reflect changes I made if necessary
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have notified the reviewer via Shortcut or Slack that this is ready for review
  • Front-end: Checked sm, md, lg screen resolutions for effective responsiveness
  • Backend-end: Documented service configuration changes or created related devops stories

Reviewer(s) checklist

  • Front-end: I've reviewed the Figma design and confirmed that changes match the spec.
  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

Copy link

This pull request has been linked to Shortcut Story #22997: Update Beacon footer.

<li>
<a href={EXTERNAL_LINKS.DOCUMENTATION} target="_blank" rel="noreferrer">
Documentation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looked really long after adding Pricing. Shortening the word to Docs makes it more in line with the others and it's common to see Docs used on other sites.

Copy link
Contributor

@pdeziel pdeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating the links!

@daniellemaxwell daniellemaxwell merged commit a9cda0c into develop Dec 15, 2023
12 checks passed
@daniellemaxwell daniellemaxwell deleted the sc-22997 branch December 15, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants