Sc 23124 #829
Merged
Sc 23124 #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #23124: Sandbox layout. |
daniellemaxwell
commented
Jan 15, 2024
| @@ -28,6 +29,9 @@ function AppLayout({ children, Breadcrumbs }: PageProps) { | |||
| return ( | |||
| <> | |||
| <Topbar Breadcrumbs={Breadcrumbs} isOnboarded={isOnboarded} profileData={loaderData} /> | |||
| {/* TODO: Display SandboxBanner only to user's with the sandbox account type. | |||
There was a problem hiding this comment.
A condition will be added in a future story to display this component to the correct user.
daniellemaxwell
commented
Jan 15, 2024
| @@ -10,8 +10,9 @@ import { TbPlayFootball } from 'react-icons/tb'; | |||
| import { EXTERNAL_LINKS, PATH_DASHBOARD } from '@/application'; | |||
| import { MenuItem } from '@/types/MenuItem'; | |||
|
|
|||
| export const SIDEBAR_WIDTH = 250; | |||
| export const TOPBAR_HEIGHT = 60; | |||
| /* TODO: Verify if styles are used and remove if not. */ | |||
There was a problem hiding this comment.
After setting these styles to 0, I didn't notice any issues while checking the site. I was experiencing some issues with hot reload being slow during development, so I plan to create a story to check again to be sure. After that, I'll know for sure if these styles can be removed. I decided to keep the variables here to make it easier to find in case I do need to set the styles again.
pdeziel
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
SandboxLayoutthat will be displayed to users with thesandboxaccount type.AlertfromTopbartoSandboxAlertcomponent and update background and text colors.absolute positionstyling fromTopbarcomponent to prevent additional whitespace from appearing in UI.Fixes SC-23124 & SC-23121
Notes:
The
SandboxLayoutwill not display if this PR is run locally. The layout was made visible during development, but has been commented out until a condition is added in a future story to display it to the correct user type.A Figma design has not been created for the
Sandboxfeature.Type of change
Acceptance criteria
https://www.awesomescreenshot.com/video/24060202?key=be099e8d43e373bf95b8d411646d9c42
Definition of Done
Reviewer(s) checklist