Display sandbox layout to sandbox users #830
Conversation
… after completing onboarding
|
This pull request has been linked to Shortcut Story #23123: Create hook to check the user's account type. |
| .toUpperCase(); | ||
| } | ||
| export const getInitials = (name: string) => { | ||
| const nameArray = name?.split(' ') || ['']; |
There was a problem hiding this comment.
While toggling between onboarded and not onboarded user states, I kept getting an undefined error related to this function. Using optional chaining (? after name) didn't completely resolve it, so [''] was added as a fallback.
There was a problem hiding this comment.
the updated function is easier to follow as well - thanks for making this fix!
| @@ -16,6 +16,8 @@ export function useUpdateProfile(): ProfileUpdateMutation { | |||
| queryClient.invalidateQueries({ queryKey: [RQK.MEMBER_LIST] }); | |||
| queryClient.invalidateQueries({ queryKey: [RQK.MEMBER_DETAIL] }); | |||
| queryClient.invalidateQueries({ queryKey: [RQK.PROFILE] }); | |||
| queryClient.invalidateQueries({ queryKey: [RQK.ORG_DETAIL] }); | |||
There was a problem hiding this comment.
This change informs React Query that the data for these queries is now stale, due to a user completing the onboarding process, and should be re-fetched.
There was a problem hiding this comment.
Thanks for noticing the issue and making the fix!
| .toUpperCase(); | ||
| } | ||
| export const getInitials = (name: string) => { | ||
| const nameArray = name?.split(' ') || ['']; |
There was a problem hiding this comment.
the updated function is easier to follow as well - thanks for making this fix!
| @@ -16,6 +16,8 @@ export function useUpdateProfile(): ProfileUpdateMutation { | |||
| queryClient.invalidateQueries({ queryKey: [RQK.MEMBER_LIST] }); | |||
| queryClient.invalidateQueries({ queryKey: [RQK.MEMBER_DETAIL] }); | |||
| queryClient.invalidateQueries({ queryKey: [RQK.PROFILE] }); | |||
| queryClient.invalidateQueries({ queryKey: [RQK.ORG_DETAIL] }); | |||
There was a problem hiding this comment.
Thanks for noticing the issue and making the fix!
Scope of changes
SandboxLayoutto sandbox users who have completed onboarding.getInitialsfunction to resolve an error experienced during development.getInitialsfunction.org namedidn't appear in theSidebarafter completing onboarding by invalidating theorg listandorg detailqueries.Note: A test will be added in a separate PR.
Fixes SC-23123, SC-23125, & SC-23347
Type of change
Acceptance criteria
https://www.awesomescreenshot.com/video/24094232?key=a812e61e398631659e307c58a6e24836
Definition of Done
Reviewer(s) checklist