Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 23170 #831

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Sc 23170 #831

merged 7 commits into from
Jan 18, 2024

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Jan 17, 2024

Scope of changes

Adds component tests for the OnboardingLayout and SandboxLayout components. Also adds a little padding to the sandbox sidebar to make heading and avatar appear more align with the topbar and banner component.

A test for the Dash Layout was added in the past.

Fixes SC-23170

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

[Copy acceptance criteria checklist from story for reviewer, or add a brief acceptance criteria here]

[Front-End: add screenshots/videos of changes made]

Definition of Done

  • I have manually tested the change running it locally (having rebuilt all containers) or via unit tests
  • I have added unit and/or integration tests that cover my changes
  • I have added new test fixtures as needed to support added tests
  • I have updated the dependencies list if necessary (including updating yarn.lock and/or go.sum)
  • I have recompiled and included new protocol buffers to reflect changes I made if necessary
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have notified the reviewer via Shortcut or Slack that this is ready for review
  • Front-end: Checked sm, md, lg screen resolutions for effective responsiveness
  • Backend-end: Documented service configuration changes or created related devops stories

Reviewer(s) checklist

  • Front-end: I've reviewed the Figma design and confirmed that changes match the spec.
  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

Copy link

This pull request has been linked to Shortcut Story #23170: Beacon layout test.

@daniellemaxwell daniellemaxwell marked this pull request as ready for review January 17, 2024 22:00
@daniellemaxwell daniellemaxwell marked this pull request as draft January 17, 2024 22:29
@daniellemaxwell daniellemaxwell marked this pull request as ready for review January 18, 2024 16:09
Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the tests!

@bbengfort bbengfort merged commit 0bf2b1d into develop Jan 18, 2024
12 checks passed
@bbengfort bbengfort deleted the sc-23170 branch January 18, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants