-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sc 12283/db validation #86
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
927a881
Add validation to member, project, and topic models
daniellemaxwell cadadf9
Test validation and add validate method to update functions
daniellemaxwell b68e1e8
Add validation test to models and update NotFound path tests
daniellemaxwell aefc8e6
Correct TopicUpdate NotFound test
daniellemaxwell 3b5359d
Update create and update handler tests to work with db validation
daniellemaxwell 450f161
Create validation for functions that don't require TenantID and updat…
daniellemaxwell eca5e28
Add check for resource name and separate ID validation from other data
daniellemaxwell 72bf399
Remove ValidateID method
daniellemaxwell 9166384
Remove validate from CreateProject
daniellemaxwell 60bb506
Remove validation from create tests
daniellemaxwell 4e834be
Minor test update
daniellemaxwell 457c692
Merge branch 'main' into sc-12283/db-validation
pdeziel 442c36d
Add check for empty name string in tests
daniellemaxwell File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's add a test case for this and to the other models so that we protect ourselves against regressions when we make future changes to the validation code.