Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorize Middleware #90

Merged
merged 3 commits into from Jan 17, 2023
Merged

Authorize Middleware #90

merged 3 commits into from Jan 17, 2023

Conversation

bbengfort
Copy link
Contributor

@bbengfort bbengfort commented Jan 16, 2023 •
edited

Scope of changes

Implements permission-based authorization middleware.

Fixes SC-12734

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

This is a port of Authorize middleware that we had in previous code so the review should be fairly lightweight.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

This PR is blocked by #88

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #12734: Authorization Middleware.

@bbengfort bbengfort marked this pull request as ready for review January 16, 2023 23:36
pdeziel
pdeziel approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@pdeziel pdeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pdeziel pdeziel merged commit ed33ed9 into main Jan 17, 2023
@pdeziel pdeziel deleted the sc-12734/authz branch January 17, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeziel pdeziel pdeziel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbengfort @pdeziel