Integrate AuthN and AuthZ into Quarterdeck #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #12739: Integrate Authenticate and Authorize middleware. |
pdeziel
approved these changes
Jan 19, 2023
| req.Header.Set("Authorization", "Bearer "+token) | ||
| return nil | ||
| } | ||
| } |
There was a problem hiding this comment.
This should work for now, I'm leaning towards the context method but it's hard to tell which way I like better until I actually start implementing it.
|
|
||
| // require.NoError(err, "should return an empty list") | ||
| // require.Empty(rep.APIKeys) | ||
| // require.Empty(rep.NextPageToken) |
There was a problem hiding this comment.
I'll finish the tests in the story where I actually implement the API list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Implements the
AuthenticateandAuthorizeendpoints into Quarterdeck and creates some client stubs for authentication to setup testing.Fixes SC-12739
Type of change
Acceptance criteria
This PR influences SC-12797 because it starts towards a solution.
Author checklist
Reviewer(s) checklist