Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this is null in Map.RaiseFinish #5

Closed
k3tamina opened this issue Jul 18, 2013 · 3 comments
Closed

this is null in Map.RaiseFinish #5

k3tamina opened this issue Jul 18, 2013 · 3 comments

Comments

@k3tamina
Copy link

To reproduce this bug:

  1. Modify Map.Events.Cs as follows
  2. Run MapManager.DeleteLocation (or DeleteLocation from angelscript)

Because of this == null, the instructions following the added lines will produce an exception.

Map.Events.Cs

...
void RaiseFinish(bool to_delete)
{
if (this == null)
Global.Log("this == null in Map.RaiseFinish");
if (Finish != null)
Finish(this, new MapFinishEventArgs(this, to_delete));
}
...

@k3tamina
Copy link
Author

I've checked the same thing with Critter.RaiseFinish and the problem didn't occur.
But I didn't check Item.RaiseFinish (or other methods with the same name).

@BartAdv
Copy link
Contributor

BartAdv commented Jul 18, 2013

Hm, I've recently changed some things in this regard, namely following commit: 5161de0

I didn't test it myself yet, but be sure you're using latest executables, and latest mono sources as well

@BartAdv
Copy link
Contributor

BartAdv commented Jul 19, 2013

OK, there was unnecesary and premature call that was removing mono handle before the events were raised, fixed, just fetch latest binaries from latest release

@BartAdv BartAdv closed this as completed Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants