Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add lint job to CI #49

Merged
merged 1 commit into from Jan 7, 2020
Merged

build: add lint job to CI #49

merged 1 commit into from Jan 7, 2020

Conversation

sum2000
Copy link
Member

@sum2000 sum2000 commented Jan 7, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files           3        3           
  Lines         226      226           
=======================================
  Hits          216      216           
  Misses          8        8           
  Partials        2        2
Impacted Files Coverage Δ
format.go 94.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d730e22...667fea8. Read the comment docs.

Copy link
Member

@morningvera morningvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@@ -42,14 +42,14 @@ type UnpackedError struct {
// Unpack returns UnpackedError type for a given golang error type.
func Unpack(err error) UnpackedError {
e := UnpackedError{}
switch err.(type) {
switch err := err.(type) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sum2000 sum2000 merged commit 763f865 into master Jan 7, 2020
@sum2000 sum2000 deleted the ci/lint branch January 7, 2020 18:21
tomsquest pushed a commit to tomsquest/eris that referenced this pull request Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants