-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace zerorpc with normal HTTP Rest API #404
Projects
Comments
@LefterisJP are we doing this for v1.0.0 or after the vue rewrite? both should be viable since we have extracted the functionality to the service. |
100% after. |
This was referenced Oct 19, 2019
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Definition
Zerorpc is a pain in the ass the way Rotkehlchen has evolved.
We need to have a hack in long running API calls to make sure that gevent does at least 1 context switch every 10 seconds to avoid the dreaded heartbeat error: https://github.com/rotkehlchenio/rotkehlchen/blob/605d56edf46d20d090e4d3dad94becd88c8749a5/rotkehlchen/accounting/accountant.py#L397
The module used both in python but more importantly in node for zerorpc is outdated and not maintained. Upgrading to a new electron version becomes harder and harder since the package needs to be forked and maintained by me to do so.
Dependency to ZeroMQ and ZeroRPC goes away
Some bugs that pop up are suspected to be due to the way zerorpc handles communication between backend and client.
Task
Remove zerorpc server from the backend. Replace with a normal rest HTTP API server.
Remove zerorpc client from the frontend side. Replace with simple RPC queries.
The text was updated successfully, but these errors were encountered: