Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for activated modules and make the modules distinction even clearer #1084

Closed
LefterisJP opened this issue Jun 13, 2020 · 1 comment · Fixed by #1272
Closed

Add setting for activated modules and make the modules distinction even clearer #1084

LefterisJP opened this issue Jun 13, 2020 · 1 comment · Fixed by #1272
Assignees
Milestone

Comments

@LefterisJP
Copy link
Member

Problem Definition

At the moment everything rotki checks, runs as the app runs. This may eventually become really expensive and time consuming due to the amount of blockchain and external service queries for each module.

Additionally we may at some point want to have premium only modules which can only be activated if the user has a premium subscription so separating modules in a clean way already is a good idea.

Task

Backend

  • Add a new setting. active_modules. It's a list of strings. Each string is a module name. Valid names for now are: makedao_dsr, makerdao_vaults.
  • Split makerdao.py into makerdao_dsr and makerdao_vaults and activate them only if the user has the module activated.
  • Add new error code in API calls if the module is not activated.

Frontend

  • Allow the user to set the active modules.
  • For makerdao DSR and for makerdao vaults process the module not activated error and show a useful message to the user.
@LefterisJP
Copy link
Member Author

So @kelsos this requires frontend work. The backend work has already been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants