Application Menu on OSX does not show the "Get Rotki Premium" button

[isidorosp]

Problem Definition

After logging in, if the user is not a premium user the application menu should be re-drawn to show a "Get Rotki Premium" button. On Windows and Linux this appears to work, but not on OSX. Figure out what's going on.

[isidorosp]

@CPatchane You're on developing on OSX right? I know perhaps this issue isn't immediately appealing but is there any chance you could look into this one?

As a starting point, you would have to do some digging in background.ts on this one, specifically around

ipcMain.on('PREMIUM_USER_LOGGED_IN', (event, args) => {
...

In the area related to re-drawing the menu. As a starting point I would be trying to figure out if this ipc call is firing or not. If it is, if the menu is being redrawn or not, or if there is just some issue in trying to draw a menu item in OSX that isn't an actual menu but an item in and of itself (i.e. it does not have a submenu).

[CPatchane]

@isidorosp Yes, I can a look into it. Thanks for the context here, do you have a screenshot of what should be the correct display here?

[isidorosp]

@isidorosp Yes, I can a look into it. Thanks for the context here, do you have a screenshot of what should be the correct display here?

Sure I can show you what it looks like on Windows for example.

Before a user logs in, this is what the appbar looks like

If a user without premium logs in, this is what the appbar looks like after login (the" Get Rotki Premium" button has been added)

[CPatchane]

@isidorosp Your guess was right, it seems that we can't draw a menu item without providing the submenu array (an empty array will give a menu showing (empty)). I can't find something about that behaviour in the documentation but I guess it's an OSX limitation here to avoid redirecting from an app bar item.

So I guess the best we can get here should be something like: