Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal comma dropped while editing manual balances #4606

Closed
apertamono opened this issue Jul 25, 2022 · 2 comments
Closed

Decimal comma dropped while editing manual balances #4606

apertamono opened this issue Jul 25, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@apertamono
Copy link

apertamono commented Jul 25, 2022

I'm not asking for support. This is one of the results of a usability test.

Problem Definition

Under Manual Balances, my XMR balance was 12.34 (represented as 12,34 according to my settings) but when I edit it, it's shown as 1234 in the form. When I edit the location, the decimal is removed again, and the amount increases by orders of magnitude if I don't re-enter the decimal comma. That's not what I'm paying attention to when I'm editing the location. The same happened for 8.642 Waves, represented as 8,642 and changed to 8642 in the form. (Of course these are not the real amounts.)

This error disappears when I set the decimal separator to a period. It doesn't occur either when editing a custom price for an NFT under Non Fungible Balances.

Logs

I turned on debugging, but I can't find anything relating to this action in rotkelchen.log. Is there a front-end log?

System Description

Operating system: Windows 10 Pro version 21H1 & Windows 10 Home 21H2 (locale is NL, decimal commas are the default)
Rotki version: 1.25.0

@LefterisJP
Copy link
Member

This is a bug @ProkhorZ!

Thank you for reporting it.

I can actually easily reproduce it.

  1. Create a manual balance of say ETH and set it to 5,555.23
  2. Set decimals separator as: , and thousands separator as .. So basically the opposite of the default
  3. Try to edit the balance. The field will appear as 555.523

@LefterisJP LefterisJP added this to the 1.25.1 milestone Jul 25, 2022
@LefterisJP LefterisJP added the bug Something isn't working label Jul 25, 2022
@kelsos kelsos self-assigned this Jul 27, 2022
@LefterisJP
Copy link
Member

Should be fixed by #4617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants