Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing information and use mypy as part of the tests #49

Closed
2 tasks
LefterisJP opened this issue Apr 29, 2018 · 1 comment
Closed
2 tasks

Add typing information and use mypy as part of the tests #49

LefterisJP opened this issue Apr 29, 2018 · 1 comment
Labels
enhancement New feature or request tests Testing infrastructure failures or additions

Comments

@LefterisJP
Copy link
Member

Rotkehlchen uses python 3.6 and thus we can specify types in the code and use static type checking with mypy.

This will help find potential bugs and enforce proper types.

  • Specify types in all functions
  • Use mypy as part of the travis tests
@LefterisJP LefterisJP added enhancement New feature or request tests Testing infrastructure failures or additions labels Apr 29, 2018
This was referenced Jun 23, 2018
Closed
Merged
@LefterisJP
Copy link
Member Author

This has already been done. Not with strict mode, but mypy rotkehlchen/ tools/data_faker --ignore-missing-imports works both locally and on the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tests Testing infrastructure failures or additions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LefterisJP