Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show asset graph in asset collection view #6444

Closed
LefterisJP opened this issue Aug 1, 2023 · 0 comments · Fixed by #6455
Closed

Show asset graph in asset collection view #6444

LefterisJP opened this issue Aug 1, 2023 · 0 comments · Fixed by #6455

Comments

@LefterisJP
Copy link
Member

Problem Definition

Normally in the asset view we show the asset graph. But if the asset is part of a multi-chain (or other) collection the asset view shows the breakdown nicely, but does not show the graph

2023-08-01_12-09

We should definitely show a graph there too. The reason we currently don't is that it's not possible to ask for the graph of an asset collection from the backend. So this is a frontend and backend problem.

But it's solvable and we should have it implemented.

Task

  • Backend: The asset graph data endpoint should accept an asset collection. If a collection is given then the asset data of collection members should be summed up for the timestamps where multiple assets of the collection have snapshot value and returned.
  • Frontend: If the asset view is of a collection, adjust the code accordingly to make it work after the backend work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant