Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kraken staking assets with set unstaking days #6587

Closed
LefterisJP opened this issue Sep 10, 2023 · 1 comment
Closed

Support kraken staking assets with set unstaking days #6587

LefterisJP opened this issue Sep 10, 2023 · 1 comment
Labels
bug Something isn't working exchange Issues related to integration with an exchange
Milestone

Comments

@LefterisJP
Copy link
Member

Problem Definition

A user came in our discord and complained they get weird assets such as SOl03. GRT28. KAVA21. ATOM21. DOT28. in rotki.

2023-09-10_144510

We have code that reads the staked assets and maps them to the actual asset here:

if kraken_name.endswith(('.S', '.M')):
# this is a staked coin. For now since we don't show staked coins
# consider it as the normal version. In the future we may perhaps
# differentiate between them in the balances https://github.com/rotki/rotki/issues/569
kraken_name = kraken_name[:-2]
if kraken_name.endswith('.HOLD'):
kraken_name = kraken_name[:-5]

Kraken later added options for different staking APY by adding days to unstake for the asset. More days to unstake, more APY.

But it seems that by doing so kraken also added new undocumented functionality to the API and now the staked assets may also contain the number of days between the asset symbol and the .S. So GRT28.S, ATOM21.S etc.

Task

Fix it. Probably by making the asset_from_kraken function take into account potential numbers in between and ignore them.

@LefterisJP LefterisJP added bug Something isn't working exchange Issues related to integration with an exchange labels Sep 10, 2023
@LefterisJP LefterisJP added this to the 1.30.2 milestone Sep 10, 2023
@LefterisJP
Copy link
Member Author

This should now be fixed and either go to 1.30.2 or 1.31.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exchange Issues related to integration with an exchange
Projects
None yet
Development

No branches or pull requests

1 participant