feat (metamask): add swap decoder #7092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7092 +/- ##
===========================================
+ Coverage 71.67% 71.75% +0.08%
===========================================
Files 1217 1218 +1
Lines 105449 105422 -27
Branches 12261 12266 +5
===========================================
+ Hits 75578 75646 +68
+ Misses 28142 28047 -95
Partials 1729 1729
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OjusWiZard
force-pushed
the
feat/metamask
branch
3 times, most recently
from
6807ada
to
67b49cf
Compare
LefterisJP
reviewed
Dec 13, 2023
OjusWiZard
force-pushed
the
feat/metamask
branch
2 times, most recently
from
60456bc
to
f1bf1be
Compare
LefterisJP
reviewed
Dec 14, 2023
|
|
||
| for event in context.decoded_events: | ||
| # Edit the full amount in the swap's receive event | ||
| if ( |
There was a problem hiding this comment.
Why did you resolve this? You are still iterating all events to find an event you have already found. The in_event right?
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard
force-pushed
the
feat/metamask
branch
from
f1bf1be
to
976aa8c
Compare
LefterisJP
temporarily deployed
to
cassette-merge
GitHub Actions
Inactive
|
rotki/test-caching/tree/feat/metamask was successfully merged |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7022
Add a Metamask decoder to decode the swaps done through Metamask on Ethereum, Polygon, Arbitrum, and Optimism.