Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process kraken rewards program events #7526

Draft
wants to merge 1 commit into
base: bugfixes
Choose a base branch
from

Conversation

yabirgb
Copy link
Member

@yabirgb yabirgb commented Feb 22, 2024

This PR addresses two issues:

  • Handle .F assets comming from kraken
  • Process deposits for the rewards program.

It is missing:

  • the unstaking event since we don't have data. I requested @tewshi to unstake a little amount to generate an event and check but it takes 7 days

edit: I've created a ticket to kraken since it is a bit confusing and I'm waiting for a response

This PR addresses two issues:

- Handle .F assets comming from kraken
- Process deposits for the rewards program.
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eecbafd) 80.51% compared to head (999641d) 80.25%.
Report is 6 commits behind head on bugfixes.

Files Patch % Lines
rotkehlchen/exchanges/kraken.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           bugfixes    #7526      +/-   ##
============================================
- Coverage     80.51%   80.25%   -0.27%     
============================================
  Files          1098     1098              
  Lines        106663   106785     +122     
  Branches      13330    13353      +23     
============================================
- Hits          85881    85697     -184     
- Misses        18703    18992     +289     
- Partials       2079     2096      +17     
Flag Coverage Δ
backend 80.52% <83.33%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LefterisJP added a commit to LefterisJP/rotkehlchen that referenced this pull request Feb 26, 2024
Fix rotki#7526

Also adjust and modernize the liquity decoding tests.

Signed-off-by: Lefteris Karapetsas <lefteris@refu.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant