Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix UI for notification and calendar #7816

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 78.84615% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 81.01%. Comparing base (e8c7e75) to head (f1276bd).

Files Patch % Lines
frontend/app/src/composables/message-handling.ts 30.00% 7 Missing ⚠️
.../app/src/composables/history/events/tx/decoding.ts 77.77% 2 Missing ⚠️
...end/app/src/composables/history/events/tx/index.ts 50.00% 1 Missing ⚠️
frontend/app/src/composables/info/chains.ts 96.55% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7816      +/-   ##
===========================================
+ Coverage    77.33%   81.01%   +3.67%     
===========================================
  Files          958     1164     +206     
  Lines        62875   107545   +44670     
  Branches     11045    12714    +1669     
===========================================
+ Hits         48626    87127   +38501     
- Misses       12066    18235    +6169     
  Partials      2183     2183              
Flag Coverage Δ
frontend_integration 60.68% <56.25%> (+5.49%) ⬆️
frontend_unit 79.17% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit 41f1eea into rotki:develop Apr 24, 2024
14 checks passed
@kelsos kelsos deleted the update-notification-ui branch April 24, 2024 08:39
LefterisJP added a commit to vijithreddy/rotki that referenced this pull request May 13, 2024
Fix rotki#7816

Signed-off-by: Lefteris Karapetsas <lefteris@refu.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants