Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat (ZkSync-lite): Notify decoding progress #7955

Merged
merged 1 commit into from
May 21, 2024
Merged

Feat (ZkSync-lite): Notify decoding progress #7955

merged 1 commit into from
May 21, 2024

Conversation

OjusWiZard
Copy link
Member

@OjusWiZard OjusWiZard commented May 20, 2024 •
edited

Checklist

  • Notify progress of decoding zksync-lite transactions through a new WS message type

@OjusWiZard OjusWiZard added the ready for peer review Backend PR ready to be reviewed by colleagues label May 20, 2024
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.73%. Comparing base (82342a4) to head (02ba897).
Report is 423 commits behind head on bugfixes.

Files Patch % Lines
rotkehlchen/chain/zksync_lite/manager.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           bugfixes    #7955      +/-   ##
============================================
+ Coverage     80.26%   80.73%   +0.47%     
============================================
  Files          1098     1177      +79     
  Lines        106799   108476    +1677     
  Branches      13360    12868     -492     
============================================
+ Hits          85717    87574    +1857     
+ Misses        18995    18666     -329     
- Partials       2087     2236     +149
Flag Coverage Δ
backend 80.85% <88.88%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yabirgb
yabirgb reviewed May 20, 2024
View reviewed changes
rotkehlchen/api/websockets/typedefs.py Outdated Show resolved Hide resolved
rotkehlchen/chain/zksync_lite/manager.py Show resolved Hide resolved
rotkehlchen/chain/zksync_lite/manager.py Outdated Show resolved Hide resolved
rotkehlchen/chain/zksync_lite/manager.py Outdated Show resolved Hide resolved
rotkehlchen/chain/zksync_lite/manager.py Outdated Show resolved Hide resolved
@OjusWiZard OjusWiZard closed this May 21, 2024
@OjusWiZard OjusWiZard deleted the feat/zksync-lite branch May 21, 2024 13:35
@OjusWiZard OjusWiZard restored the feat/zksync-lite branch May 21, 2024 13:38
@OjusWiZard OjusWiZard reopened this May 21, 2024
@OjusWiZard OjusWiZard changed the base branch from develop to bugfixes May 21, 2024 13:47
yabirgb
yabirgb reviewed May 21, 2024
View reviewed changes
rotkehlchen/chain/zksync_lite/manager.py Outdated Show resolved Hide resolved
rotkehlchen/chain/zksync_lite/manager.py Outdated Show resolved Hide resolved
rotkehlchen/chain/zksync_lite/manager.py Outdated Show resolved Hide resolved
@OjusWiZard OjusWiZard force-pushed the feat/zksync-lite branch 3 times, most recently from dcd4009 to 25afb95 Compare May 21, 2024 15:38
@OjusWiZard
Fix (ZkSync-lite): Notify decoding progress
02ba897 
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
@yabirgb yabirgb added ready for final review Backend PR ready to be reviewed by great Lefteris and removed ready for peer review Backend PR ready to be reviewed by colleagues labels May 21, 2024
LefterisJP
LefterisJP approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LefterisJP LefterisJP merged commit acb7d2c into rotki:bugfixes May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yabirgb yabirgb yabirgb left review comments

@LefterisJP LefterisJP LefterisJP approved these changes

Assignees
No one assigned
Labels
ready for final review Backend PR ready to be reviewed by great Lefteris
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zksync lite websockets messages
3 participants
@OjusWiZard @LefterisJP @yabirgb