Add new episodes so Windows tests will pass #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2023
|
In order to make this work, we need to push this into an upstream PR with the same name as the PR in rotki's repository. So what I will do is also push your branch into the upstream with a different name so we can rerun tests on rotki/rotki#6398 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of tests fail on windows with the
vcr.errors.CannotOverwriteExistingCassetteException: Can't overwrite existing cassetteerror. Using these cassettes allows them to pass. I know that at least one of these tests fail to use the existing cassette on windows since the parameters in the url for the API call is not in the same order as it is on linux, and so VCR tries to overwrite the existing cassette but fails.Other cassettes are added to take into account the underlying was changed to make them pass on windows e.g. test_curve_cache()