Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Theme): fix slow app when the theme is changed #208

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

@lukicenturi lukicenturi requested a review from a team as a code owner June 12, 2024 04:12
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 67.76%. Comparing base (e1c8b58) to head (c31931e).

Files Patch % Lines
src/composables/theme.ts 4.16% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   67.76%   67.76%           
=======================================
  Files         105      105           
  Lines       18738    18737    -1     
  Branches      694      694           
=======================================
  Hits        12697    12697           
+ Misses       6041     6040    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/composables/theme.ts Outdated Show resolved Hide resolved
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks :)

@kelsos kelsos merged commit fe61212 into rotki:main Jun 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants