Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unified release action #73

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Add unified release action #73

merged 3 commits into from
Feb 1, 2023

Conversation

WardBrian
Copy link
Collaborator

@WardBrian WardBrian commented Jan 31, 2023

This builds on @sethaxen's work in #70 to create a unified release action for the repo. It also updates a few documentation pages in anticipation of the release.

The steps the Action takes are roughly:

  1. Replace the version numbers in all interfaces with the new version
  2. Build the .tar.gz file we attach to a release
  3. Update the Julia Artifacts.toml file
  4. Push a commit to the repo with the above changes
  5. Create a tag and release
  6. Push to PyPI (@roualdes this will require us adding a Secret to the repository for a PyPI token once)
  7. Comment on the commit from 4 with a @JuliaRegistrator register (@roualdes this will require following the pre-registration instructions here https://github.com/JuliaRegistries/Registrator.jl once)

If any step up to and including 5 fails, you can re-run the script without any problem. If any step after 5 fails, you need to check a box on the Workflow page while running which will skip re-creating the release, and will just upload to PyPI/JuliaRegistries

After the automated release we can manually edit the releases page to include the change log.

After this is merged I suggest we more or less immediately run it to release 1.0.1 which will start the Julia Registration process. We can also discuss if we want to eventually make the Python interface able to download the C++ source, like the Julia interface now can, but I decided to leave that for later.

@WardBrian WardBrian linked an issue Jan 31, 2023 that may be closed by this pull request
Copy link
Owner

@roualdes roualdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for giving a go at setting this up.

+1 to immediately release 1.0.1 to get the Julia Registration process kickstarted.

@WardBrian
Copy link
Collaborator Author

@roualdes I just wrote to you about some config details for this that need to be done in repository settings before this would work fully

Julia tests may fail initially since link won't exist
@WardBrian WardBrian merged commit c09d2cf into roualdes:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registering BridgeStan.jl?
2 participants