-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS project added #18
Conversation
- MaterialFrame.macOS project added - macOSMaterialFrameRenderer added - InternalLogger updated to be available in macOS assembly
AssemblyDescription and README updated with macOS
Wow nice 😍 |
I'll try to find some time to merge this in the following weeks :) |
all those great PR that awaiting to be merged x) |
i've tried your renderer and it works fine but it seems that effects Images Radius some how! 🤔 update : no image button and no frame can give images radius on macOS you should only use Image.Clip property. |
you are right - unfortunately there is no |
It's happening :) |
You didn't change the nuspec file so I dont think we can build a nuget :/ |
Shouldn't we add a line in the Readme for Mac initialization as well ? |
makes sense, i forgot that in the updated readme - process should be identical to iOS |
also, would you be interested in making a post on Sharpnado about your PR ? |
yes sure, i would love to 🥳 |
2 impediments prevent this PR to go through release in Nuget package:
|
the package is ready now. who are you You can also come up with a totally different plan, it's fine by me :) let me know what you think |
If you don't really have time or just the desire to write a post, you can just answers the question here, and I will just turn them into an interview in a blog post :) |
@roubachof sorry for the delay, i just came back from a long vacation ⛵ |
Hey @roubachof 👋
i have added a macOS renderer for
Sharpnado.MaterialFrame
. It's based on the iOS renderer with little modifications specific toAppKit
- it's great that most of the magic is happening inCoreAnimation
/CoreGraphics
which can be shared between iOS and macOS.Commit messages
MaterialFrame.macOS
project addedmacOSMaterialFrameRenderer
addedInternalLogger
updated to be available in macOS assemblyI have also updated
Sharpnado.Acrylic
and added a macOS project here roubachof/Sharpnado.Acrylic#1Screenshots
![img_712937192](https://user-images.githubusercontent.com/3210391/114149781-8fc2b100-991b-11eb-9e7d-19cfb8401417.png)