Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS project added #18

Merged
merged 2 commits into from
May 28, 2021
Merged

macOS project added #18

merged 2 commits into from
May 28, 2021

Conversation

nor0x
Copy link
Contributor

@nor0x nor0x commented Apr 9, 2021

Hey @roubachof 👋

i have added a macOS renderer for Sharpnado.MaterialFrame. It's based on the iOS renderer with little modifications specific to AppKit - it's great that most of the magic is happening in CoreAnimation / CoreGraphics which can be shared between iOS and macOS.

Commit messages

I have also updated Sharpnado.Acrylic and added a macOS project here roubachof/Sharpnado.Acrylic#1

Screenshots
img_712937192

- MaterialFrame.macOS project added
- macOSMaterialFrameRenderer added
- InternalLogger updated to be available in macOS assembly
AssemblyDescription and README updated with macOS
@mhrastegari
Copy link
Contributor

Wow nice 😍

@roubachof
Copy link
Owner

I'll try to find some time to merge this in the following weeks :)

@roubachof
Copy link
Owner

all those great PR that awaiting to be merged x)

@mhrastegari
Copy link
Contributor

mhrastegari commented May 9, 2021

i've tried your renderer and it works fine but it seems that effects Images Radius some how! 🤔
even in your screenshots you can see that profile image doesn't have any Corner radius.

update : no image button and no frame can give images radius on macOS you should only use Image.Clip property.

@nor0x
Copy link
Contributor Author

nor0x commented May 10, 2021

i've tried your renderer and it works fine but it seems that effects Images Radius some how! 🤔
even in your screenshots you can see that profile image doesn't have any Corner radius.

update : no image button and no frame can give images radius on macOS you should only use Image.Clip property.

you are right - unfortunately there is no ImageButton on macOS. In roubachof/Sharpnado.Acrylic@026b830 i have replaced it with a regular image + gesture recognizer. I will update the sample and use an EllipseGeometry for clipping 👍

@roubachof
Copy link
Owner

It's happening :)

@roubachof roubachof merged commit 1ab11a7 into roubachof:master May 28, 2021
@roubachof
Copy link
Owner

roubachof commented May 28, 2021

You didn't change the nuspec file so I dont think we can build a nuget :/

@roubachof
Copy link
Owner

Shouldn't we add a line in the Readme for Mac initialization as well ?
Saw you put an Init method on the renderer.

@nor0x
Copy link
Contributor Author

nor0x commented May 28, 2021

Shouldn't we add a line in the Readme for Mac initialization as well ?
Saw you put an Init method on the renderer.

makes sense, i forgot that in the updated readme - process should be identical to iOS

@roubachof
Copy link
Owner

also, would you be interested in making a post on Sharpnado about your PR ?

@nor0x
Copy link
Contributor Author

nor0x commented May 30, 2021

yes sure, i would love to 🥳

@roubachof
Copy link
Owner

2 impediments prevent this PR to go through release in Nuget package:

  1. nuspec is not updated to make a mac os nuget package
  2. acrylic effect is inverted in mac os implemented (should be white glow on top and shadow on the bottom but it's the other way around on mac os renderer).

@nor0x nor0x mentioned this pull request Jun 30, 2021
roubachof added a commit that referenced this pull request Jul 12, 2021
@roubachof
Copy link
Owner

the package is ready now.
So if you still want to write a post on sharpnado you are more than welcome :)
If you want to proceed, I just need a markdown with images/gifs in a compressed folder.
If you want ideas on how to structure the post, here is what could be a plan

who are you
why did you use sharpnado tabs?
why you had this idea?
first implementation
communication on the PR
final adjustments
It could be small amount of text for each points, or long ones, it's up to you !

You can also come up with a totally different plan, it's fine by me :)

let me know what you think

@roubachof
Copy link
Owner

If you don't really have time or just the desire to write a post, you can just answers the question here, and I will just turn them into an interview in a blog post :)

@nor0x
Copy link
Contributor Author

nor0x commented Aug 23, 2021

@roubachof sorry for the delay, i just came back from a long vacation ⛵
i have sent you some blogabble content via email, please let me know if this works for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] macOS Support
3 participants