Skip to content

Commit

Permalink
Fix shebang regex in Python lexer (#1172)
Browse files Browse the repository at this point in the history
The Python lexer only supported minor version numbers for shebangs
involving `python2`. Minor versions of Python 3 should also be included.
This commit corrects that problem and supports minor version numbers
higher than 9.
  • Loading branch information
pyrmont committed Jun 17, 2019
1 parent 48daca1 commit 5fb0ea6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/rouge/lexers/python.rb
Expand Up @@ -12,7 +12,7 @@ class Python < RegexLexer
mimetypes 'text/x-python', 'application/x-python'

def self.detect?(text)
return true if text.shebang?(/pythonw?(3|2(\.\d)?)?/)
return true if text.shebang?(/pythonw?(?:[23](?:\.\d+)?)?/)
end

def self.keywords
Expand Down
4 changes: 3 additions & 1 deletion spec/lexers/python_spec.rb
Expand Up @@ -23,9 +23,11 @@

it 'guesses by source' do
assert_guess :source => '#!/usr/bin/env python'
assert_guess :source => '#!/usr/local/bin/python3'
assert_guess :source => '#!/usr/bin/python2'
assert_guess :source => '#!/usr/bin/python2.7'
assert_guess :source => '#!/usr/local/bin/python3'
assert_guess :source => '#!/usr/local/bin/python3.5'
assert_guess :source => '#!/usr/local/bin/python3.14'
deny_guess :source => '#!/usr/bin/env python4'
end
end
Expand Down

0 comments on commit 5fb0ea6

Please sign in to comment.