-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve line numbers #149
Comments
Those styles aren't inlined because it's reasonable that someone might want to override them, which they can't do if it's in the |
I'd prefer no inline styles at all, like my examples. |
Run |
I just get
might be a Windows thing. |
Regardless, I think using CSS line numbers is much better in principle as it separates the content from the style. I see why you chose the current table style now though and why it seemed so odd :P |
Would you mind spending some time hunting down that bug? I think it's important that you're able to look at the visual specs. |
Encoding to <%= Rouge.highlight(sample.demo.encode('utf-8'), sample, @formatter) %> at No dice with
However, with the ones I can view, I see what you mean now; I can choose to select the line numbers or not, works nicely. It's not as nice as the CSS method, but definitely better than my table version. What do you think about adding the two CSS methods then? |
Ah, so it's being read as the wrong encoding. Do you think you could add Thanks! |
Yep, just adding |
This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days. If you would like this issue to remain open, please reply and let us know if the issue is still reproducible. |
I made a gist showing a few different ways to implement line numbers, let me walk you through the pros and cons...
Current:
CSS only:
Separate lines:
Table with separate lines:
Just throwing ideas out here, I think all three methods have advantages over the current system - I don't like the markup and CSS being used atm.
I propose adding the last two options, I don't know how difficult it is to wrap each line in a tag, but there is definitely a reason why it's the most common approach.
With this, people can do their zebra striping and have fluid gutters, but are also are given the option to use the CSS3 counter instead of HTML and copy code without the line numbers etc. Doing this with only CSS wouldn't need line numbers enabled at all, but that approach is basically a hack.
The text was updated successfully, but these errors were encountered: