rougify should treat file input as utf8 #417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had apparently an utf-8 issue where the rougify (cli) did not treat a file as utf8 on windows (even though it was saved as utf8 according to several editors.. sigh).
In #149 it was mentioned to correct the File.read calls to use encoding, but due to slightly different code in cli.rb I suspect that that specific instance might have been overlooked.