No implicit conversion of IO into String

[jneen]

It seems like #417 was a little overzealous - the FileReader class had been introduced to distinguish between stdin (or '-') and file names. When using rougify to highlight stdin, we now try to call File.read($stdin, encoding: 'utf-8'), which throws an error.

[jneen]

@japj could you take a look at this please?

[jneen]

(when you get a chance - if you don't have the time I'm happy to fix it of course)

[japj]

I'll have a look later today, not sure exactly atm how to have a reproduceable test for this to prevent regression in the future. My ruby is fairly rusty

[japj]

Ok, I am a bit lost on how to solve this issue due to not programming in ruby for a looong time and the unknowns of the IO subsystem.

Should https://github.com/jneen/rouge/blob/master/lib/rouge/cli.rb#L16 return a different kind of object (this is what I am assuming should happen as the 'correct' fix, but I'm not sure what object it should be exactly for L26 to also still work correctly).

Or should https://github.com/jneen/rouge/blob/master/lib/rouge/cli.rb#L26 contain the old code in case of stdin, but then there is duplication on the case input/when part?

[jneen]

I think you can embed the encoding into the File object with File.new(fname, 'r:utf-8') or similar

[japj]

I guess this can be closed then?

[jneen]

Yep!