Add support for raw/verbatim blocks in Jinja/Twig #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblessing
reviewed
Oct 1, 2018
pyrmont
added
the
author-action
Jinja provides a `raw` tag and Twig provides a `raw` tag in its 1.x version and a `verbatim` one in newer versions. To make the code simple, since the Twig lexer extends from the Jinja one, the latter holds the logic for both tags.
robin850
force-pushed
the
twig-jinja-raw-blocks
branch
from
25febe9
to
3c55915
Compare
pyrmont
added
needs-review
|
@robin850 I submitted a PR to your branch with some suggested changes. That seemed preferable to making you copy and paste my code :) You can ask me questions on that PR or wherever is easiest. |
pyrmont
added
author-action
Feature.twit jinja raw blocks
|
Thanks for the PR, @robin850. Sorry it took such a long time to get it merged in! |
pyrmont
removed
the
author-action
|
No problem, thanks for all your work on this project ! |
stof
reviewed
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request adds proper support for
rawandverbatimblocks inside the Jinja and Twig lexers.For Jinja:
For Twig:
Fixes #982
Fixes #983
Have a nice day !