Add Basic Ada Language Support #1021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Ada defined keywords and types, as well as support for strings, integers, operators, and comments. Added both body and spec file extensions, .adb and .ads respectively, as well as AdaCore GPRbuild tool file extension, .gpr. Resolves rouge-ruby#824
vidarh
suggested changes
Jan 11, 2019
spec/visual/samples/ada
Outdated
| @@ -0,0 +1,343 @@ | |||
| ------------------------------------------------------------------------------ | |||
There was a problem hiding this comment.
I'm not sure it's appropriate to use a GPL'd file as a sample for Rouge. Rouge is MIT licensed, and while it may not be a problem to include it as a sample, it might be preferable to use another sample. Also, the point of the sample file is to show the effect of the different rules of the lexer. Since this lexer is very basic, I don't think it's necessary to have such a large sample.
Remove the GPL'd sample file, and replace it with a simpler sample file that shows all the types, keywords and symbols.
|
@btmalone I'm sorry it's taken so long to get to this. The updated sample is definitely simpler but perhaps a little too simple. Could you expand it a little to include some procedures as well? |
pyrmont
added
the
author-action
pyrmont
removed
the
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Ada defined keywords and types, as well as support for
strings, integers, operators, and comments. Added both body
and spec file extensions, .adb and .ads respectively, as well
as AdaCore GPRbuild tool file extension, .gpr.
Resolves #824