Markdown code block fixes #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vidarh
commented
Dec 23, 2018
vidarh
commented
- Makes Markdown lexer recognise code blocks (~~~/```) that startes at the very first line of a file.
- Makes Markdown lexer recognise code blocks if the lexer is passed input line by line with the "continue" flag.
- Makes Markdown lexer apply guesser to code-blocks when no name is provided.
* Code blocks starting at the first line of a file are not recognised. * Code blocks are not recognised if the file is lexed line by line. * While the lexer tries to pass lines of code in to #find_fancy, it does not set the name to 'guess' when none is provided, so it achieves nothing.
…put. The same issue causes it to fail recognition at the start of a source, and when parsing line by line, as it depended on a multi-line regex match. This instead matches on either just the first line or the whole block if provided, and if only the first block is provided, it pushes a dynamic state that recognizes the end of the code block but delegates all other input to the sub-lexer.
|
Hi, I'm trying to use Rouge for a Ruby text-editor, and since I'm doing incremental syntax highlighting and various additional filtering I ran into some corner cases with the Markdown lexer. It adds some complexity, so happy to discuss/try alternative approaches if you don't think this is the way to do it. |
|
@vidarh Can you do a force push here to run a fresh build of Travis? Something like $ git commit --amend
$ git push --forceshould do the trick. |
pyrmont
added
the
author-action
vidarh
force-pushed
the
markdown-code-block-fixes
branch
from
6c43168
to
a74e135
Compare
|
Sorry, @vidarh. I'd missed that you'd updated this! |
pyrmont
removed
the
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.